Skip to content

speed up login - #147

Merged
ahmedyousry27 merged 1 commit into
mainfrom
speaking-exercise
Jul 17, 2026
Merged

ahmedyousry27 merged 1 commit into
mainfrom
speaking-exercise

Conversation

@ahmedyousry27

@ahmedyousry27 ahmedyousry27 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Improve job-interview RAG retrieval and generation so exercises focus on realistic interview responses.
  • Add quality review with one corrective regeneration attempt and a 502 response if quality still fails.
  • Reject irrelevant interview exercises about clothing, grooming, travel, timing, and preparation checklists.
  • Keep the login page visible during Keycloak initialization using silent SSO.
  • Restore authentication controls after browser back navigation.
  • Remove the logo from frontend and Keycloak login/registration pages.
  • Hide the listening practice plan from the frontend.
  • Increase Keycloak resources to reduce authentication latency while remaining within the namespace quota.

Testing

  • Frontend unit tests: 20 passed
  • Frontend ESLint: passed
  • Frontend production build: passed
  • Helm rendering: passed
  • RAG prompt and quality-review tests added

Summary by CodeRabbit

  • New Features

    • Improved authentication startup and sign-in flows, including more reliable session restoration.
    • Added silent authentication checks to help maintain logged-in sessions.
  • Bug Fixes

    • Hidden the fixed listening practice plan from learning plan lists.
    • Improved recovery of authentication and loading states after browser navigation.
  • Style

    • Simplified authentication page branding and refined Keycloak login page spacing and layout.

@ahmedyousry27 ahmedyousry27 added this to the milestone 8 milestone Jul 17, 2026
@ahmedyousry27 ahmedyousry27 self-assigned this Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cd032a0d-8eda-434f-ab06-f8bbfc68ff0b

📥 Commits

Reviewing files that changed from the base of the PR and between b099601 and fc97117.

📒 Files selected for processing (9)
  • frontend/public/silent-check-sso.html
  • frontend/src/App.jsx
  • frontend/src/api/mappers.js
  • frontend/src/api/mappers.test.js
  • frontend/src/auth/keycloak.js
  • frontend/src/pages/AuthPage.jsx
  • frontend/src/styles.css
  • helm/team-drops/files/keycloak-theme/interviewmate/login/resources/css/login.css
  • helm/team-drops/values-rancher.yaml
💤 Files with no reviewable changes (2)
  • frontend/src/pages/AuthPage.jsx
  • frontend/src/styles.css

📝 Walkthrough

Walkthrough

The frontend adds silent SSO handling, restores authentication UI state after browser navigation, hides a fixed learning plan, removes authentication branding elements, adjusts Keycloak theme spacing, and increases Keycloak resource requests and limits.

Changes

Authentication flow

Layer / File(s) Summary
Silent SSO initialization
frontend/public/silent-check-sso.html, frontend/src/auth/keycloak.js
Adds the silent SSO redirect page and configures Keycloak initialization to use it before login or registration.
Authentication UI state recovery
frontend/src/App.jsx
Restores loading state on pageshow, clears stale authentication state during bootstrap and session reset, and preserves login and registration error handling.

Learning-plan filtering

Layer / File(s) Summary
Hidden learning-plan mapping
frontend/src/api/mappers.js, frontend/src/api/mappers.test.js
Filters out the “Everyday Listening Practice” plan and tests that remaining plans are mapped correctly.

Authentication presentation

Layer / File(s) Summary
Authentication branding layout
frontend/src/pages/AuthPage.jsx, frontend/src/styles.css, helm/team-drops/files/keycloak-theme/interviewmate/login/resources/css/login.css
Removes frontend logo styling and Keycloak decorative elements while reducing authentication card spacing across desktop and mobile layouts.

Keycloak resource configuration

Layer / File(s) Summary
Keycloak resource values
helm/team-drops/values-rancher.yaml
Increases Keycloak CPU and memory requests and limits.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant App
  participant Keycloak
  participant SilentCheckSso
  Browser->>App: bootstrap authentication
  App->>Keycloak: initializeAuth()
  Keycloak->>SilentCheckSso: load silent SSO redirect page
  SilentCheckSso->>Browser: postMessage(location.href, location.origin)
  Browser->>Keycloak: complete initialization
  App->>Keycloak: login() or register()
  Keycloak-->>App: authentication result
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes Summary and Testing, but it omits the required Related Issue and Changes sections from the template. Add the missing Related Issue and Changes sections, and format the verification details under a dedicated Verification section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the login/authentication-focused nature of the changes, though it is broad.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch speaking-exercise

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ahmedyousry27
ahmedyousry27 merged commit 2c2e359 into main Jul 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant