Skip to content

add more memory for listening - #156

Merged
ahmedyousry27 merged 1 commit into
mainfrom
production_vlaues
Jul 19, 2026
Merged

add more memory for listening#156
ahmedyousry27 merged 1 commit into
mainfrom
production_vlaues

Conversation

@ahmedyousry27

@ahmedyousry27 ahmedyousry27 commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

fix registration layout on mobile and increase listening memory

Changes

Reallocated 256Mi from monitoring to GenAI:
GenAI: 1280Mi → 1536Mi — observed usage was 1239Mi
Prometheus: 320Mi → 192Mi — observed usage was 58Mi
Loki: 320Mi → 192Mi — observed usage was 75Mi
User, learning, progress, Keycloak, and database resources were not reduced.

Validation passed:

Both Helm charts lint
Prometheus and Loki requests remain within their limits
Rendered total is 5096Mi / 5120Mi

Summary by CodeRabbit

  • Bug Fixes

    • Improved the mobile login experience with a full-page layout, clearer typography, and better alignment on small screens.
  • Performance

    • Adjusted monitoring memory limits to better match resource usage.
    • Increased the memory requested by the GenAI service for improved capacity.

@ahmedyousry27 ahmedyousry27 self-assigned this Jul 19, 2026
@AET-DevOps26 AET-DevOps26 deleted a comment from coderabbitai Bot Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
Not Found - https://docs.github.com/rest/issues/comments#update-an-issue-comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
helm/team-drops/values-rancher.yaml (1)

13-19: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Increase the GenAI memory request, not only the limit.

The changed value is under resources.limits; resources.requests.memory remains 512Mi. Kubernetes will therefore schedule this workload with only 512Mi reserved, so the stated 1536Mi request is not achieved. Update the request as well, or clarify that only the limit should increase.

Proposed fix
     requests:
       cpu: 100m
-      memory: 512Mi
+      memory: 1536Mi
     limits:
       cpu: 500m
       memory: 1536Mi
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@helm/team-drops/values-rancher.yaml` around lines 13 - 19, Update the
resources.requests.memory value in the Helm values to 1536Mi so it matches the
GenAI memory limit; leave the existing CPU settings and memory limit unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@helm/team-drops/values-rancher.yaml`:
- Around line 13-19: Update the resources.requests.memory value in the Helm
values to 1536Mi so it matches the GenAI memory limit; leave the existing CPU
settings and memory limit unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c92e5dfe-cd6a-4a7b-9373-64169603be61

📥 Commits

Reviewing files that changed from the base of the PR and between 8020365 and 8fb3059.

📒 Files selected for processing (3)
  • helm/team-drops-monitoring/values-rancher.yaml
  • helm/team-drops/files/keycloak-theme/interviewmate/login/resources/css/login.css
  • helm/team-drops/values-rancher.yaml

@ahmedyousry27
ahmedyousry27 merged commit 3972e46 into main Jul 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant