add more memory for listening - #156
Conversation
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
helm/team-drops/values-rancher.yaml (1)
13-19: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winIncrease the GenAI memory request, not only the limit.
The changed value is under
resources.limits;resources.requests.memoryremains512Mi. Kubernetes will therefore schedule this workload with only 512Mi reserved, so the stated 1536Mi request is not achieved. Update the request as well, or clarify that only the limit should increase.Proposed fix
requests: cpu: 100m - memory: 512Mi + memory: 1536Mi limits: cpu: 500m memory: 1536Mi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@helm/team-drops/values-rancher.yaml` around lines 13 - 19, Update the resources.requests.memory value in the Helm values to 1536Mi so it matches the GenAI memory limit; leave the existing CPU settings and memory limit unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@helm/team-drops/values-rancher.yaml`:
- Around line 13-19: Update the resources.requests.memory value in the Helm
values to 1536Mi so it matches the GenAI memory limit; leave the existing CPU
settings and memory limit unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c92e5dfe-cd6a-4a7b-9373-64169603be61
📒 Files selected for processing (3)
helm/team-drops-monitoring/values-rancher.yamlhelm/team-drops/files/keycloak-theme/interviewmate/login/resources/css/login.csshelm/team-drops/values-rancher.yaml
Summary
fix registration layout on mobile and increase listening memory
Changes
Reallocated 256Mi from monitoring to GenAI:
GenAI: 1280Mi → 1536Mi — observed usage was 1239Mi
Prometheus: 320Mi → 192Mi — observed usage was 58Mi
Loki: 320Mi → 192Mi — observed usage was 75Mi
User, learning, progress, Keycloak, and database resources were not reduced.
Validation passed:
Both Helm charts lint
Prometheus and Loki requests remain within their limits
Rendered total is 5096Mi / 5120Mi
Summary by CodeRabbit
Bug Fixes
Performance