fix(infra): use helm-computed redirect URL for k8s Enable Banking flow - #110
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CD workflow's Helm deploy step removes the ChangesCD Workflow Helm Value Change
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The EB_REDIRECT_URL secret holds the Azure VM callback URL and is shared
with the Azure compose deploy. Overriding the helm value with it made the
Rancher banking-service register the Azure /callback as the Enable Banking
redirect target, so users finishing bank auth on the k8s app landed on the
Azure frontend, whose backend 403'd the callback (and could never complete
a session stored in the Rancher database anyway).
With the override removed, the chart falls back to its computed default:
https://{tumid}-devops-ss26.stud.k8s.aet.cit.tum.de/callback
azzabaatout
force-pushed
the
fix/k8s-eb-redirect-url
branch
from
July 7, 2026 20:45
2d4f9e2 to
1a97dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Connecting a bank (PayPal) through Enable Banking on the Rancher deployment (https://ge42cer-devops-ss26.stud.k8s.aet.cit.tum.de/) always failed after authorization with:
POST https://team-team-dev-7d5c6b.polandcentral.cloudapp.azure.com/api/banking/callback 403 (Forbidden)Root cause
cd.ymloverrodebankingService.enableBanking.redirectUrlwith the sharedEB_REDIRECT_URLsecret, which holds the Azure VM callback URL (it's also used byinfra-deploy.ymlfor the compose stack). So the k8s banking-service registered the Azure/callbackwith Enable Banking, and users finishing bank auth on the Rancher app were redirected to the Azure frontend, whose backend rejected the callback with a CORS 403 — and could never have completed it anyway, since the auth session state lives in the Rancher Postgres.Fix
Drop the override. The helm chart already computes the correct per-environment default when the value is empty (
bankingService-deployment.yaml):https://{tumid}-devops-ss26.stud.k8s.aet.cit.tum.de/callbackThe Azure deploy pipeline keeps using
EB_REDIRECT_URLand is untouched.Verified
POST /api/banking/callbackon the Rancher backend with the Rancher origin passes CORS and reaches the banking-service; the client is built with relative API URLs and handles/callback?code=…&state=….https://ge42cer-devops-ss26.stud.k8s.aet.cit.tum.de/callbackas a redirect URL in the Enable Banking Control Panel, otherwisePOST /api/banking/connectwill fail validation.Closes #111
Summary by CodeRabbit