Skip to content

Commit 2f22251

Browse files
sivralmacmacal
andauthored
Apply suggestions from code review
Format Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
1 parent 85cbde9 commit 2f22251

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

aegis_grpc/include/aegis_grpc/robot_control_service.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ class RobotControlServiceImpl final
4444
const proto_aegis_grpc::v1::Twist* request,
4545
google::protobuf::Empty* response) override;
4646

47-
// TODO(issue#83) add MoveIt2 actions to plan&execute trajectories to targets in Joints and Poses.
4847
grpc::Status GotoPose(
4948
grpc::ServerContext* context,
5049
const proto_aegis_grpc::v1::Pose* request,

aegis_grpc/python_client/aegis_grpc_client/grpc_client.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ async def servo_tcp(
281281
# TODO(issue#83) add MoveIt2 actions to plan&execute trajectories to targets in Joints and Poses.
282282
async def goto_pose(
283283
self,
284-
position: Union[tuple[float, float, float], np.ndarray], # np.array([vx,vy,vz])
284+
position: Union[tuple[float, float, float], np.ndarray],
285285
orientation: Union[tuple[float, float, float, float], np.ndarray],
286286
) -> tuple[bool, str]:
287287
"""
@@ -296,9 +296,9 @@ async def goto_pose(
296296
self._check_connected()
297297

298298
if isinstance(position, np.ndarray):
299-
position = tuple(position.tolist())
299+
position = tuple(position)
300300
if isinstance(orientation, np.ndarray):
301-
orientation = tuple(orientation.tolist())
301+
orientation = tuple(orientation)
302302

303303
pose = geometry_msgs_pb2.Pose(
304304
position=geometry_msgs_pb2.Point(
@@ -321,7 +321,6 @@ async def goto_pose(
321321
self.logger.error(f"Failed to send robot motion command: {e}")
322322
raise
323323

324-
# TODO(issue#83) add MoveIt2 actions to plan&execute trajectories to targets in Joints and Poses.
325324
async def goto_joints(
326325
self,
327326
names: list[str],
@@ -339,7 +338,7 @@ async def goto_joints(
339338
self._check_connected()
340339

341340
if isinstance(positions, np.ndarray):
342-
positions = positions.tolist()
341+
positions = tuple(positions)
343342

344343
joint_state = sensor_msgs_pb2.JointState(
345344
name=names,

0 commit comments

Comments
 (0)