Skip to content

Commit b2bdcd2

Browse files
committed
FIX: missing iter outside for-loop
1 parent c940727 commit b2bdcd2

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

robotiq_hande_driver/hardware/src/hande_hardware_interface.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ HWI::CallbackReturn RobotiqHandeHardwareInterface::on_init(const HWI::HardwareIn
7171

7272
HWI::CallbackReturn RobotiqHandeHardwareInterface::on_configure(
7373
const rlccp_lc::State& /*previous_state*/) {
74-
int result;
74+
int result = FAILURE_MODBUS;
7575

7676
RCLCPP_INFO(get_logger(), "Connecting to ModbusRTU");
7777
RCLCPP_DEBUG(
@@ -83,24 +83,24 @@ HWI::CallbackReturn RobotiqHandeHardwareInterface::on_configure(
8383
data_bits_,
8484
stop_bit_);
8585

86-
8786
result = gripper_driver_.configure();
8887

89-
for (int iter = 0; result == FAILURE_MODBUS && iter < RECONNECT_MAX_ITER; iter++) {
90-
RCLCPP_DEBUG(get_logger(), "Reconfiguring Hand-E Gripper attempt: %d; result: %d", iter, result);
91-
88+
for(int iter = 0; result == FAILURE_MODBUS && iter < RECONNECT_MAX_ITER; iter++) {
89+
RCLCPP_DEBUG(
90+
get_logger(), "Reconfiguring Hand-E Gripper attempt: %d; result: %d", iter, result);
91+
9292
wait_100ms();
9393
wait_100ms();
94-
94+
9595
gripper_driver_.cleanup();
9696
result = gripper_driver_.configure();
9797
}
98-
99-
if(iter == RECONNECT_MAX_ITER) {
98+
99+
if(result == FAILURE_MODBUS) {
100100
RCLCPP_INFO(get_logger(), "Failed to configure Hand-E Gripper");
101101
return HWI::CallbackReturn::FAILURE;
102102
}
103-
103+
104104
RCLCPP_INFO(get_logger(), "Connected");
105105
return HWI::CallbackReturn::SUCCESS;
106106
}

0 commit comments

Comments
 (0)