Refactor - Multithread modbus communication#21
Merged
macmacal merged 46 commits intohumble-develfrom Aug 18, 2025
Merged
Conversation
slimasziom
approved these changes
Aug 18, 2025
robotiq_hande_driver/hardware/include/robotiq_hande_driver/communication.hpp
Outdated
Show resolved
Hide resolved
robotiq_hande_driver/hardware/include/robotiq_hande_driver/communication.hpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After an attempt of introduction of a separate thread for the modbus communication in #19, more changes in the codebase were needed.
This resulted in a major refactor of the codebase.
aegis_rosrepository: Gripper communication takes too much bandwidth (causes RTDE errors) aegis_ros#38ros2_control_exampleswarnings is not showing anymore, so it was possible to to re-enable the-Werrorcompile flag Fix compile warnings from the ros2_control example #5 .SocatManager- therobotiq_hande_drivercan now manage the externalsocatprocess and spawn it at will (via new boolean URDF param calledcreate_socat_tty).namespace colourin a brand newutils.hpp.application.hpp/cppintohande_gripper.hpp/cpp.uint8_t bytes_[]intostd::array<uint8_t, *>.communication.cpp/hpptoprotocol_logic.cpp/hpp.*.hpps to*.cpps.chronoandthreadinstead ofusleep()).Communicationconfig intoCommunicationConfigstruct.GRIPPER_OUTPUT_FIRST_REGandGRIPPER_INPUT_FIRST_REG.frequency_hz(int) to control the ammount of sleep rate in new threadcreate_socat_tty(bool) to create a virtual serial port,ip_adressandportto configure the creation of virtual serial port withsocat,ttyparam totty_portfor better clarity.Note
For this PR we should use the squash marge option
Motivation and context
Related PRs
frequency_hz,create_socat_tty,ip_adress&portaegis_ros#49frequency_hz,create_socat_tty,ip_adress&portrobotiq_hande_description#14Related issues
libmodbus#22How has this been tested?
aegis_rosstack.Checklist
Clickup task: 869972nfu