Skip to content

Conversation

@kanglant
Copy link
Collaborator

@kanglant kanglant commented Sep 9, 2025

Create MaxText Package Tests workflow, which builds maxtext package and run cpu/tpu unit/integration tests.

Save the built maxtext distributions as action artifacts. Artifacts are retained within the workflow run for 90 days.

Create a docker image, which has all the system level deps for maxtext and no python libraries pre-installed except pip and uv, for the package testing in a clean python environment.

Test with local configs/assets/test_assets files for now.

Tests

The MaxText Package Tests presubmit passed.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@kanglant kanglant force-pushed the package_test_ci branch 4 times, most recently from 5f18910 to 2ded8b4 Compare September 11, 2025 22:35
pyproject.toml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not doing the rename yet; soon; but not yet

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kanglant. Please try the two disabled tests again with the dependencies from #2301 to see if it helps. If the tests still fail, then they can be disabled like you have in this PR.

For others, Kanglan is adding new Github Actions tests and still keeping the old ones. So we are still covered by that. We will remove the old ones later when we are satisfied with how they are performing like Kanglan mentioned

Copy link
Collaborator

@NuojCheng NuojCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Save the built maxtext distributions as action artifacts. Artifacts are retained
within the workflow run for 90 days.

Create a docker image for the package testing

Test with local configs/assets/test_assets files for now.
@Rohan-Bierneni
Copy link
Collaborator

Rohan-Bierneni commented Sep 13, 2025

Do we want to run these tests as part of every unit test even though they are duplicate of the old ones, the difference is setup is using maxtext package? I think we could have them run only on scheduled runs or a nightly run to make sure they work properly so we can save on resources and also on total unit test time? @kanglant @bvandermoon

@bvandermoon
Copy link
Collaborator

Do we want to run these tests as part of every unit test even though they are duplicate of the old ones, the difference is setup is using maxtext package? I think we could have them run only on scheduled runs or a nightly run to make sure they work properly so we can save on resources and also on total unit test time? @kanglant @bvandermoon

@Rohan-Bierneni we are planning to make these the main MaxText CI tests. @kanglant is currently keeping the old ones in place until we build confidence in the new ones. There should not be both running for long. Also as FYI, she is not updating the GPU tests for now

Copy link
Collaborator

@parambole parambole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for adding this.

@copybara-service copybara-service bot merged commit 94539bb into main Sep 13, 2025
24 checks passed
@copybara-service copybara-service bot deleted the package_test_ci branch September 13, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants