-
Notifications
You must be signed in to change notification settings - Fork 418
Create a CI workflow that build maxtext package and run tests against it #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5f18910 to
2ded8b4
Compare
pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not doing the rename yet; soon; but not yet
11c6b8a to
2ec8fb6
Compare
bvandermoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kanglant. Please try the two disabled tests again with the dependencies from #2301 to see if it helps. If the tests still fail, then they can be disabled like you have in this PR.
For others, Kanglan is adding new Github Actions tests and still keeping the old ones. So we are still covered by that. We will remove the old ones later when we are satisfied with how they are performing like Kanglan mentioned
NuojCheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Save the built maxtext distributions as action artifacts. Artifacts are retained within the workflow run for 90 days. Create a docker image for the package testing Test with local configs/assets/test_assets files for now.
2ec8fb6 to
af57a93
Compare
|
Do we want to run these tests as part of every unit test even though they are duplicate of the old ones, the difference is setup is using maxtext package? I think we could have them run only on scheduled runs or a nightly run to make sure they work properly so we can save on resources and also on total unit test time? @kanglant @bvandermoon |
@Rohan-Bierneni we are planning to make these the main MaxText CI tests. @kanglant is currently keeping the old ones in place until we build confidence in the new ones. There should not be both running for long. Also as FYI, she is not updating the GPU tests for now |
parambole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for adding this.
Create MaxText Package Tests workflow, which builds maxtext package and run cpu/tpu unit/integration tests.
Save the built maxtext distributions as action artifacts. Artifacts are retained within the workflow run for 90 days.
Create a docker image, which has all the system level deps for maxtext and no python libraries pre-installed except
pipanduv, for the package testing in a clean python environment.Test with local configs/assets/test_assets files for now.
Tests
The MaxText Package Tests presubmit passed.
Checklist
Before submitting this PR, please make sure (put X in square brackets):