-
Notifications
You must be signed in to change notification settings - Fork 418
Update disruption manager for the refactored recipes #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
782a480 to
97604b2
Compare
58e629c to
9c3df71
Compare
cacca03 to
e57aae1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just some minor comments
e2bc864 to
a9e1b99
Compare
54203cd to
6363e4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
6363e4f to
b65dfb7
Compare
| class Framework(Enum): | ||
| PATHWAYS = "pathways" | ||
| MCJAX = "mcjax" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think CONTROLLER_TYPE or similar would be a better name here
Description
Update disruption manager to work with the refactored recipes
FIXES: b/441333068
Tests
python3 -m benchmarks.recipes.pw_suspend_resumeThe disruption SIGTERM will be triggered at the target step:
The disruption SIGILL will be triggered at the target step:
It will follow the previous behaviors
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.