-
Notifications
You must be signed in to change notification settings - Fork 419
GRPO refactoring #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPO refactoring #2530
Conversation
149a3dc to
e72906d
Compare
|
🤖 Hi @A9isha, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
8453278 to
e356292
Compare
babbccb to
ec3e2d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @A9isha !
In addition to the comments - can you please clarify what tests you have performed, i.e. the hardware, model, and more importantly with what configs (since that's the main change here)?
ec3e2d4 to
3249753
Compare
34aec47 to
0b83e8b
Compare
d521428 to
13609f1
Compare
13609f1 to
1c627c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dummy approval since an owner approval is needed :D
PiperOrigin-RevId: 828688487 clean up
Description
Refactoring how to run GRPO with Tunix MaxText vLLM and Pathways (TMVP). We are adding the new files under
src/MaxText/rland the config filerl.ymlinsrc/MaxText/configs. The entry level main file issrc/MaxText/rl/train_rl.pyWork was started by @mydatascience and completed by @A9isha
Tests
I have tested the code on Llama3.1-8b and Llama3.1-70b on v7x-128, v5p-64
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.