Skip to content

Conversation

@NuojCheng
Copy link
Collaborator

@NuojCheng NuojCheng commented Nov 1, 2025

Description

In this PR we made following changes:

  1. Add sharding constraints/reshards for explicit sharding bug-free;
  2. Add attention tests on explicit sharding, including expert parallelism, context parallelism, and mixture of two

Tests

Model_name: deepseek3-test
TL;DR:

Full FSDP

FSDP + TP

FSDP + CP

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@NuojCheng NuojCheng added the draft Draft PR label Nov 1, 2025
@NuojCheng NuojCheng force-pushed the chengnuojin-explicit-deepseek branch 7 times, most recently from 34e1ab2 to 97cc3bd Compare November 6, 2025 03:24
@NuojCheng NuojCheng force-pushed the chengnuojin-explicit-deepseek branch from 97cc3bd to 0b4a8b5 Compare November 6, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

draft Draft PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants