-
Notifications
You must be signed in to change notification settings - Fork 419
Consolidate legacy checkpoint scripts into folder #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This Pull Request successfully consolidates legacy checkpoint scripts into a new src/MaxText/utils/ckpt_scripts folder. The changes are well-executed, primarily involving path updates across documentation, shell scripts, and Python import statements.
🔍 General Feedback
- All file renames and path updates are consistent and correctly reflect the new directory structure.
- The changes align with the stated goal of organizing checkpoint utilities.
2f7e22d to
2263894
Compare
|
Do we also move
|
Good call! I will move that together. |
2263894 to
60f27f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Move all legacy checkpoint scripts from folder
src/MaxTextinto foldersrc/MaxText/utils/ckpt_scriptsto align with new checkpoint utilitysrc/MaxText/utils/ckpt_conversion. We have plan to migrate all legacy scripts into conversion utility in Q1 2026 timeline.This PR helps us to consolidate all scripts, and resolves b/452391826.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.