Fix Attention static-attribute error #2607
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Attentionmodule was initializingquery_normandkey_normas None at the end of__init__, which made them static attributes in Flax NNX. When the code conditionally tried to assignRMSNormorQwen3NextRMSNormmodule instances to these attributes, NNX raised a ValueError because you cannot assign module objects to static attributes.This PR fixes the issue:
query_normandkey_normare now properly initialized as either NNX modules or None based on the configuration.Fixes: b/458142671
Tests
Qwen3-4b:
Gemma3-4b
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.