Skip to content

Move src/MaxText/assets to src/maxtext/assets/tokenizers #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SurbhiJainUSC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move src/MaxText/assets to src/maxtext/assets/tokenizers #3015

SurbhiJainUSC wants to merge 1 commit into from

Conversation

@SurbhiJainUSC
Copy link
Collaborator

@SurbhiJainUSC SurbhiJainUSC commented Jan 27, 2026

Description

Move src/MaxText/assets to src/maxtext/assets/tokenizers

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SurbhiJainUSC SurbhiJainUSC force-pushed the assets_refactor branch 6 times, most recently from 9d00678 to 912dcb7 Compare January 27, 2026 22:56
@SurbhiJainUSC SurbhiJainUSC marked this pull request as ready for review January 27, 2026 23:30
dipannita08
dipannita08 approved these changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@dipannita08 dipannita08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dipannita08 dipannita08 dipannita08 approved these changes

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@SujeethJinesh SujeethJinesh Awaiting requested review from SujeethJinesh SujeethJinesh is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@mitalisi mitalisi Awaiting requested review from mitalisi mitalisi is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@shauryagup shauryagup Awaiting requested review from shauryagup shauryagup is a code owner

@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@Obliviour Obliviour Awaiting requested review from Obliviour Obliviour is a code owner

@notabee notabee Awaiting requested review from notabee notabee is a code owner

@suexu1025 suexu1025 Awaiting requested review from suexu1025 suexu1025 is a code owner

@parambole parambole Awaiting requested review from parambole parambole is a code owner

@jacoguzo jacoguzo Awaiting requested review from jacoguzo jacoguzo is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner

@gpolovets1 gpolovets1 Awaiting requested review from gpolovets1 gpolovets1 is a code owner

@mailvijayasingh mailvijayasingh Awaiting requested review from mailvijayasingh mailvijayasingh is a code owner

@jrplatin jrplatin Awaiting requested review from jrplatin jrplatin is a code owner

@patemotter patemotter Awaiting requested review from patemotter patemotter is a code owner

@Lumosis Lumosis Awaiting requested review from Lumosis Lumosis is a code owner

@shuningjin shuningjin Awaiting requested review from shuningjin shuningjin is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@NicoGrande NicoGrande Awaiting requested review from NicoGrande NicoGrande is a code owner

@jesselu-google jesselu-google Awaiting requested review from jesselu-google jesselu-google is a code owner

@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SurbhiJainUSC @dipannita08 @khatwanimohit