Add stop string support to rl.#3263
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
38cf343 to
8498485
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
8498485 to
80ed76d
Compare
80ed76d to
1fe03cb
Compare
1fe03cb to
841ee9f
Compare
khatwanimohit
approved these changes
Mar 4, 2026
bvandermoon
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces support for stop string, which tell vLLM to stop generating as soon as any of the tokens included in this field are generated. This uses the new
rollout_vllm_sampler_kwargsargument introduced here: google/tunix#1169Tests
Command:
Logs
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.