docs: add LoRA fine-tuning tutorial#3601
Draft
chiajunglien wants to merge 2 commits intoAI-Hypercomputer:jackyf/feat/lora-nnxfrom
Draft
docs: add LoRA fine-tuning tutorial#3601chiajunglien wants to merge 2 commits intoAI-Hypercomputer:jackyf/feat/lora-nnxfrom
chiajunglien wants to merge 2 commits intoAI-Hypercomputer:jackyf/feat/lora-nnxfrom
Conversation
RexBearIU
reviewed
Apr 9, 2026
docs/tutorials/posttraining/lora.md
Outdated
| scan_layers=True | ||
| ``` | ||
|
|
||
| Your fine-tuned model checkpoints will be saved here: `$BASE_OUTPUT_DIRECTORY/$RUN_NAME/checkpoints`. No newline at end of file |
Collaborator
There was a problem hiding this comment.
Also instruct the usage of maxtext_lora_to_hf script
RexBearIU
requested changes
Apr 9, 2026
RexBearIU
reviewed
Apr 10, 2026
| learning_rate="${LEARNING_RATE?}" \ | ||
| weight_dtype="${WEIGHT_DTYPE?}" \ | ||
| dtype="${DTYPE?}" \ | ||
| profiler=xplane \ |
Collaborator
There was a problem hiding this comment.
I think we don't need to use profiler in tutorial
RexBearIU
reviewed
Apr 10, 2026
|
|
||
| Your fine-tuned model checkpoints will be saved here: `$BASE_OUTPUT_DIRECTORY/$RUN_NAME/checkpoints`. | ||
|
|
||
| ## (Optional) Export Fine-tuned LoRA to Hugging Face Format |
Collaborator
There was a problem hiding this comment.
Convert should be more appropriate
RexBearIU
requested changes
Apr 10, 2026
|
|
||
| ```sh | ||
| python3 maxtext/checkpoint_conversion/maxtext_to_hf_lora.py \ | ||
| maxtext/configs/post_train/sft.yml \ |
Collaborator
There was a problem hiding this comment.
Could we remove maxtext/configs/post_train/sft.yml?
|
|
||
| ```sh | ||
| python3 maxtext/checkpoint_conversion/hf_lora_to_maxtext.py \ | ||
| maxtext/configs/post_train/sft.yml \ |
Collaborator
There was a problem hiding this comment.
Could we remove maxtext/configs/post_train/sft.yml?
| maxtext/configs/post_train/sft.yml \ | ||
| model_name="${PRE_TRAINED_MODEL?}" \ | ||
| load_parameters_path="${BASE_OUTPUT_DIRECTORY?}/${RUN_NAME?}/checkpoints/<step_number>/items" \ | ||
| base_output_directory="${BASE_OUTPUT_DIRECTORY?}/hf_lora_adaptor" \ |
Collaborator
There was a problem hiding this comment.
Rest of the file use adapter and we should align
| If your LoRA adapter is currently in Hugging Face format, you must convert it to MaxText format before it can be loaded. Use the provided conversion script: | ||
|
|
||
| ```sh | ||
| python3 maxtext/checkpoint_conversion/hf_lora_to_maxtext.py \ |
Collaborator
There was a problem hiding this comment.
we should use python3 -m maxtext.checkpoint_conversion.hf_lora_to_maxtext to align the training command
| After completing the fine-tuning process, your LoRA weights are stored in MaxText/Orbax format. To use these weights with the Hugging Face ecosystem (e.g., for inference or sharing), convert them back using the `maxtext_lora_to_hf.py` script. | ||
|
|
||
| ```sh | ||
| python3 maxtext/checkpoint_conversion/maxtext_to_hf_lora.py \ |
Collaborator
There was a problem hiding this comment.
we should use python3 -m maxtext.checkpoint_conversion.maxtext_to_hf_lora to align the training command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.