Fix package names and mark build-dependent deps as optional - #89
Open
AmelieLang wants to merge 1 commit into
Open
Fix package names and mark build-dependent deps as optional#89AmelieLang wants to merge 1 commit into
AmelieLang wants to merge 1 commit into
Conversation
- Fix finnhub -> finnhub-python (correct PyPI package name, original causes install failure) - Mark torch as optional comment (saves ~2GB, install separately if DRL needed) - Mark bt as optional comment (requires Microsoft C++ Build Tools to build on Windows)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finnhub->finnhub-python: the original package name does not exist on PyPI and causes pip install to fail for all new userstorch>=2.0.0as optional comment — saves ~2GB on default installbt>=1.2.0as optional comment — requires Microsoft C++ Build Tools to compile on WindowsTest plan