fix(data_processors): resolve KeyError by sorting scrap_data on tic column - #1438
Open
tarun1790 wants to merge 2 commits into
Open
fix(data_processors): resolve KeyError by sorting scrap_data on tic column#1438tarun1790 wants to merge 2 commits into
tarun1790 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1436
Summary of Changes
fetch_stock_data()creates aticcolumn for each ticker, butscrap_data()attempted to sort by["day", "tick"], causing aKeyError: "tick".scrap_data()to dynamically sort bytic(ortickif present) and handle empty download frames gracefully.unit_tests/preprocessors/test_yahoofinance_processor.pyvalidating multi-ticker sorting and error handling.