-
Notifications
You must be signed in to change notification settings - Fork 115
[WIP] Add flag for fast simulation to MCParticle #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 18 files 18 suites 6h 12m 50s ⏱️ Results for commit 3268d0e. ♻️ This comment has been updated with latest results. |
|
Hi @tmadlener, thanks for starting this. Here's my two cents:
|
|
Looking into the implementation of the fast simulation inside DD4hep in a bit more detail, it's not entirely clear to me where we would need to place the setting of this status. Users that implement their own fast sim model, definitely do not have access to it any longer, I think, because they only get handed the G4 quantities, but not the DD4hep wrappers around them. |
|
Maybe using |
12c2af3 to
3268d0e
Compare
|
I have added an attempt here to go via the primary map, but this doesn't seem to persist to the output (which is not currently part of the PR!). This has several issues:
I have also tried adding the information to the I could add a Other possible options would be to hook into Any input welcome :) |
BEGINRELEASENOTES
ENDRELEASENOTES
This is the start of this work. The goal in the end is to have an easy way in analysis to check whether an MCParticle has been handled by a fast simulation model or not. This will obviously also require EDM4hep and LCIO to acquire a similar flag, but I would like to finalize a few things here first before going there.
Currently there are a few open questions:
FAST_SIMULATION_TRKandFAST_SIMULATION_CALO? Or do we simply name this current flag appropriately to_CALO(as that is the main / only use case for this)?Geant4FastSimShowerModel::check_trigger, but since killing the primary track is also in user responsibility, this should probably be as well)Tagging @peter-mckeown @gaede to solicit some inupt explicitly