update collection max_size
to include limits due to ObjectID
#752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
max_size
reported by collections to include limit due toObjectID
index typeENDRELEASENOTES
Collections probably shouldn't have more elements than maximal
int
as otherwiseObjectID
index will overflow. For subset collections it's fine as their elements have ObjectID referring to other non-subset collections. It's also fine forUserDataCollection
since it isn't usingObjectID
As far as I can say
max_size
was added as part of "Container" interface and as far as I can say isn't actively used by anything in the stack. But if we can report a more realistic number then why not