Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update collection max_size to include limits due to ObjectID #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-fila
Copy link
Contributor

@m-fila m-fila commented Mar 21, 2025

BEGINRELEASENOTES

  • Update max_size reported by collections to include limit due to ObjectID index type

ENDRELEASENOTES

Collections probably shouldn't have more elements than maximal int as otherwise ObjectID index will overflow. For subset collections it's fine as their elements have ObjectID referring to other non-subset collections. It's also fine for UserDataCollection since it isn't using ObjectID

As far as I can say max_size was added as part of "Container" interface and as far as I can say isn't actively used by anything in the stack. But if we can report a more realistic number then why not

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. CI is currently suffering from some EOS problems most likely as the downloads for the test files are failing. Maybe we should consider caching them (if at all possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants