Fix: Improve RunningHub API response handling and error diagnostics#98
Open
ErbolTakhirov wants to merge 1 commit into
Open
Fix: Improve RunningHub API response handling and error diagnostics#98ErbolTakhirov wants to merge 1 commit into
ErbolTakhirov wants to merge 1 commit into
Conversation
- Validate ComfyKit response objects are not None before use - Add detailed logging of response contents for debugging - Improve error messages with response details - Add validation of required RunningHub API key configuration - Provide clear error context when RunningHub API fails This fixes the issue where empty/invalid RunningHub responses caused 'No valid JSON found' errors. Now users get detailed logs showing: - When responses are empty or invalid - What response attributes were expected vs received - Workflow input and parameters for reproduction - Configuration validation for RunningHub API key Fixes issue where v0.1.15 RunningHub cloud workflows fail with JSON parsing error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users with RunningHub Max membership were experiencing failures in v0.1.15 when using cloud workflows (both video generation and illustration generation). All workflows failed with:
"No valid JSON found: line 1 column 1 (char 0)"
While the membership and API key worked correctly on the RunningHub website, the integration in Pixelle-Video was broken, leaving 8GB VRAM GPU users with no viable cloud option.
Root Cause
The error occurred when ComfyKit received empty or invalid responses from the RunningHub API, but the code lacked:
Solution
✅ Added comprehensive response validation and error handling across all workflow services:
Changes
Benefits
Testing