Open
Conversation
added 2 commits
April 19, 2024 08:59
Contributor
|
Project have pyproject.toml file, so we don't need that req.txt. Toml file already has package list. |
Author
|
People are asking for one. |
Contributor
Well, first your install guide and your package list missing, You also installed the latest pytorch what I did was set a minimum version of PyTorch and torchvision. I should ask, "Which problem does this PR solve"? I was the one who removed requirement.txt and setup.py in favor of "pyproject.toml" for a better approach. |
Author
|
Then the README.md should be updated accordingly, because one is asked to just install the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great job, team!
I am submitting the
requirements.txtfile because many have consistently asked for one.Even though it was trained with
PyTorch:1.11.0, it seems to work just fine with2.2.1.The entire pipeline has already processed 10 million images with the specified/tested lib versions.
Driver Version: 525.147.05, CUDA Version: 12.1
Let me know if you need any further help!