fix(security): harden oauth popup messaging and prevent open redirect #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.






Security Report + Fix: OAuth popup message hardening + Open Redirect prevention
1) OAuth authorization code leakage / message spoofing risk
The
/redirectroute posted the OAuth authorizationcodetowindow.openerusingpostMessagewithtargetOrigin='*'.Additionally, the opener-side listener in oauth2-utils.ts did not strictly bind the message to:
event.source)statevalue (CSRF protection)startsWithagainst the redirect URL string)This can allow interception/spoofing of OAuth authorization codes in popup-based OAuth flows.
Fix in this PR:
postMessagetargetOrigin towindow.location.origintype: 'oauth2:code'andstateevent.originusing URL parsingevent.source === popupWindowstatewhen present2) Open redirect after third-party login
third-party-logins.tsx used the
redirectquery param directly (window.location.href = redirect), enabling open redirects.Fix in this PR:
/url.origin === window.location.originAffected files
Notes
Issues are disabled on this repository, so this PR description serves as the public vulnerability report and patch submission.