Move get_messages() from ServerGame to Game#104
Merged
Conversation
Collaborator
|
I am not sure how to review this. |
Author
|
I think it will be fine. I wasn't aware of that until now, but looking at Most of our code already uses |
aphedges
force-pushed
the
move-get_messages
branch
from
c328a55 to
0ea9c32
Compare
This allows the method to be used by clients, preventing them from ever needing to interact with the unfiltered `Game.messages` field. Hopefully, this prevents any accidental message leakage.
aphedges
force-pushed
the
move-get_messages
branch
from
0ea9c32 to
5160c52
Compare
Obertura777
pushed a commit
that referenced
this pull request
Dec 12, 2025
Move `get_messages()` from `ServerGame` to `Game`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the method to be used by clients, preventing them from ever needing to interact with the unfiltered
Game.messagesfield. Hopefully, this prevents any accidental message leakage.