fix(fkill): stop when initial signal fails - #114
Merged
Conversation
ALX99
force-pushed
the
audit/fkill-initial-signal-failure-20260805
branch
from
August 5, 2026 18:04
617618e to
920e3f7
Compare
ALX99
force-pushed
the
audit/fkill-initial-signal-failure-20260805
branch
from
August 8, 2026 18:00
d07e544 to
a41861e
Compare
ALX99
force-pushed
the
audit/fkill-initial-signal-failure-20260805
branch
3 times, most recently
from
August 13, 2026 18:04
52227bc to
6b262f2
Compare
Owner
Author
|
Revalidated and rebased this draft onto current master |
ALX99
force-pushed
the
audit/fkill-initial-signal-failure-20260805
branch
from
August 14, 2026 10:59
6b262f2 to
14decc5
Compare
ALX99
force-pushed
the
audit/fkill-initial-signal-failure-20260805
branch
from
August 14, 2026 11:05
14decc5 to
bd7a9d2
Compare
ALX99
marked this pull request as ready for review
August 14, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and impact
fkillschedules its delayed escalation even when the initial signal command fails. An invalid signal can therefore return an error from the first attempt yet still terminate the selected process five seconds later.Reproduction and observed result
Revalidated against current
master50d7c989c6603c0d5d274be2a6539b39c8db6f47using exact production blobs (dfd3e31b12d439e894cc0128a7583bd877c9fa05parent,f47c3ea992328a9d6690811b1b8492da974a2f40fixed). A temporaryfzfstub selected a disposablesleep 30; real system process tools handled signaling.BADSIGNAL: parent status 0 and target dead after 6s; fixed status 123 and target alive after 6s.TERM: parent and fixed status 0; target terminated.Root cause and fix
The initial signaling pipeline's failure status was ignored. The fix exits when that pipeline fails, before scheduling delayed escalation.
Validation commands and results
GNU Bash 5.2.37, GNU findutils 4.10.0, procps-ng 4.0.4:
bash -npassed for both.git diff --check..local/bin/fkillchanged.6b262f2cc5eaca3a245e1438ea77858d49c1a030.A fresh HTTPS clone was attempted first, but this runtime could not resolve
github.com. The branch was rebuilt from the exact current GitHubmastertree plus the validated fixed blob. Literal full-tree localgit statusandgit diff --check origin/master...HEADwere unavailable and are not claimed.Scope and risk
Only
.local/bin/fkillchanges by one failure guard. Successful signaling, the five-second grace period, escalation, multi-selection, and cancellation behavior are unchanged.