Support Megatron's a2a and deepep overlap in pipeline #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuankaichen-amd
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an interface change to enable the overlap code to run.
Functionally speaking:
2.1 GPU hangs when turbo_deepep_use_comm_stream=True, pp_warmup=False;
2.2 turbo_deepep_use_comm_stream=False, pp_warmup=False, was able to run 1 iteration and then got nan error;
2.3 turbo_deepep_use_comm_stream=False, pp_warmup=True, was able to run, but no overlaps.
We will need to follow up on the issues above, but the code change in this PR is correct and safe, unrelated to the issues.