[WIP] Refactor CLI and Add Unit Tests for Auto-Discovery #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiaoming-AMD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
Moved CLI subcommands to a dedicated subcommands directory.
Implemented a CommandRegistry to automatically discover and register subcommands.
Updated train and benchmark commands to align with the new structure.
Simplified the CLI entry point in main.py.
Added new scripts under the runner directory to support training workflows.
Improved script organization and added necessary configurations.
Created test_cli.py to test the CLI's auto-discovery mechanism and subcommand execution.
Test cases include:
Command discovery to ensure all subcommands are registered.
Execution of train and benchmark commands with valid arguments.
Handling of unknown commands with appropriate error messages.
Ensured compatibility with the refactored CLI structure.