Support torch_dist async checkpoint for latest Megatron-LM #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mat, and update the async checkpoint patch logic
wenxie-amd
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 checkpoint arguments below, which are in latest Megatron-LM
In ROCm version >= 7.1, the HIP runtime fixed a bug where, after the main process allocated pinned memory and then forked child processes, the child processes’ access to that memory would cause a segmentation fault.
libhsakmt: Don't use MADV_DONTFORK for paged memory ROCm/rocm-systems#356
So the previous patch for FileSystemWriterAsync can be removed in this case.