feat(CLI): Add Runner Library and Test Suite #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add runner/lib/ with common utilities, config handling, and validation - common.sh: Logging, environment detection, and utility functions - config.sh: Configuration parsing and validation - validation.sh: Parameter validation for distributed training - Add tests/runner/ with comprehensive test suite - test_common.sh: Tests for common library functions - test_config.sh: Tests for configuration handling - test_validation.sh: Tests for validation functions (19 tests, all passing) - run_all_tests.sh: Master test runner script All tests passing (19/19 for validation tests)
- Add 'Run Shell Tests' step to CI pipeline - Run tests/runner/run_all_tests.sh after Python unit tests - Tests runner/lib libraries (common, config, validation) - Ensures shell script quality and functionality in CI
Xiaoming-AMD
changed the title
wenxie-amd
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add shared library system for Primus CLI with comprehensive test suite (19 tests passing).
What's New
🔧 Runner Library (
runner/lib/)common.sh: Logging, error handling, utilitiesvalidation.sh: Parameter validation for distributed trainingconfig.sh: Configuration parsing and validation🧪 Test Suite (
tests/runner/)run_all_tests.sh🚀 CI Integration