feat(runner): add patch execution system with comprehensive test suite #279
+497
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add execute_patches.sh utility for conditional patch script execution with support for success (exit 0), skip (exit 2), and failure handling. Changes: - Add runner/helpers/execute_patches.sh with conditional patch execution * Supports multiple patch scripts with exit code handling * Implements skip logic for patches that don't need to run * Forces common.sh re-sourcing in subshells to avoid function inheritance issues * Provides fallback logging when common.sh is not available - Add LOG_ERROR_RANK0 function to runner/lib/common.sh * Mirrors LOG_INFO_RANK0 and LOG_SUCCESS_RANK0 pattern * Ensures rank 0-only error logging for distributed environments - Add comprehensive test suite for execute_patches.sh (36 tests) * Test no patches, single/multiple patches, skip logic * Test error handling: missing patches, unreadable files * Test failure scenarios and exit code handling * Validates stop-on-first-failure behavior - Update run_all_tests.sh to include execute_patches tests * Now runs 4 test suites with 121 total tests * All tests passing Technical fixes: - Fix subshell function inheritance issue by unsetting __PRIMUS_COMMON_SOURCED before re-sourcing common.sh in execute_patches.sh - Environment variables are inherited by subshells but functions are not, requiring explicit re-sourcing to ensure function availability
wenxie-amd
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add execute_patches.sh utility for conditional patch script execution with support for success (exit 0), skip (exit 2), and failure handling.
Changes:
Add runner/helpers/execute_patches.sh with conditional patch execution
Add comprehensive test suite for execute_patches.sh (36 tests)
Update run_all_tests.sh to include execute_patches tests