Skip to content

[Fix] fp8 option not work #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

[Fix] fp8 option not work #33

merged 1 commit into from
Apr 22, 2025

Conversation

@RuibinCheung
Copy link
Contributor

@RuibinCheung RuibinCheung commented Apr 22, 2025

@RuibinCheung RuibinCheung requested a review from wenxie-amd April 22, 2025 07:08
wenxie-amd
wenxie-amd approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@wenxie-amd wenxie-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenxie-amd wenxie-amd merged commit 4519306 into main Apr 22, 2025
2 checks passed
@RuibinCheung RuibinCheung deleted the fix_fp8_config branch July 23, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenxie-amd wenxie-amd wenxie-amd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RuibinCheung @wenxie-amd