JAX NCCL Analyser for multi-node collective communication bandwidth analysis#438
Open
amital-amd wants to merge 4 commits intomainfrom
Open
JAX NCCL Analyser for multi-node collective communication bandwidth analysis#438amital-amd wants to merge 4 commits intomainfrom
amital-amd wants to merge 4 commits intomainfrom
Conversation
added 2 commits
November 21, 2025 04:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a JAX NCCL Analyser for analyzing collective communication bandwidth in multi-node JAX distributed training workloads. The implementation provides comprehensive tooling to parse JAX traces, extract collective operations from XLA dumps, and calculate algorithmic and bus bandwidth metrics.
Key Changes:
- JAX-specific NCCL analyzer with XLA dump parsing capabilities
- Bandwidth calculation engine supporting multiple collective types (all-reduce, all-gather, reduce-scatter, all-to-all, collective-permute)
- Utility functions for automatic node-to-protobuf file mapping
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TraceLens/NcclAnalyser/jax_nccl_analyser.py | Core analyzer class implementing trace loading, XLA parsing, and bandwidth calculations |
| TraceLens/NcclAnalyser/util/xla_parser.py | XLA dump parser for extracting collective operation metadata including replica groups and tensor dimensions |
| TraceLens/NcclAnalyser/util/node_rank_to_protobuf_file_mapping.py | Utility for automatic discovery and mapping of node ranks to protobuf trace files |
| TraceLens/util.py | Added regex pattern for extracting replica_groups information from HLO operations |
| tests/test_jax_nccl_analyser.py | Unit tests covering trace loading, bandwidth scaler calculations, and end-to-end analysis |
| examples/jax_nccl_analyser_example.ipynb | Jupyter notebook demonstrating usage with detailed documentation |
| TraceLens/init.py | Export JaxNcclAnalyser class |
| TraceLens/NcclAnalyser/init.py | Export JaxNcclAnalyser from submodule |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/test_data_jax_nccl_analyser/all_gather_manual_bw_calculation.csv
Outdated
Show resolved
Hide resolved
added 2 commits
November 21, 2025 10:41
Contributor
|
@gabeweisz and @devalshahamd Any input for the PR review? This has been open quite a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
This PR introduces the JAX collective communication analyzer for TraceLens, addressing issue #262 with support for multi-node distributed training analysis.
JAX-Specific Analysis:
Scope:
The initial implementation prioritizes core bandwidth analysis for JAX workloads. Given the complexity of multi-source parsing and data aggregation—combining traces and XLA dumps for accurate bandwidth calculations— features such as synchronization analysis, multiprocessing support, and integrated reporting (similar to PyTorch NCCL analyzer) are intentionally deferred to future iterations.