get_df_xla_perf raises KeyError for FP8 and s8 dtypes in XLA kernel operands#447
Open
get_df_xla_perf raises KeyError for FP8 and s8 dtypes in XLA kernel operands#447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FP8 variants f8e4m3fnuz, f8e5m2fnuz or s8 cause KeyError
This PR addresses a
KeyErroringet_df_xla_perfwhen processing XLA kernel operands containing FP8 or int8 dtypes (e.g., f8e4m3fnuz, f8e5m2fnuz, s8). The currentdtype_to_byteslacks those types and uses direct indexing, causing theKeyErrorand breaking analysis flows in JAX profiler traces. This change adds these missing dtypes to thedtype_to_bytesmapping.Problem
dtype_to_bytesinget_df_xla_perfofTraceLens/TreePerf/tree_perf.pydoes not include:Direct indexing
dtype_to_bytes[dtype]crashes withKeyErrorwhen these appear in operands here:Changes