Skip to content

Review apml modules venice a0 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akky16 wants to merge 10 commits into
base: dev-a1
Choose a base branch
from
Open

Review apml modules venice a0 #135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bcc5de5
amd-apml: sbrmi: Add sbrmi device as per the SBRMI device instance ID
akky16 Jun 2, 2025
c77f047
amd-apml: sbtsi: Add sbtsi device as per the SBTSI device instance ID
akky16 Jun 2, 2025
416a90d
amd-apml: sbtsi: Add device IDs for socket 0 and Socket 1 for Fam:0x1…
akky16 Jun 2, 2025
3cbafb7
amd-apml: sbrmi: Add device IDs for socket 0 and Socket 1 for Fam:0x1…
akky16 Jun 2, 2025
0666518
linux: i3c: Extra info should not be updated in the driver
akky16 Jun 2, 2025
ca272c9
amd-apml: sbrmi: update label for hwmon entry to include socket_iod n…
akky16 Jun 2, 2025
2495233
amd_apml: sbtsi: update label for hwmon entry to include socket & die…
akky16 Jun 2, 2025
1a104c9
amd-apml: alertl: Add support for AMD APML Alert_L platform driver
sathyapk Jun 2, 2025
df7cc4b
amd-apml: alertl: dts changes for Morocco & Congo
akky16 May 30, 2025
0f54429
amd-apml: doc: Documentation for dts changes for Alert_L module
akky16 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion drivers/i3c/device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@ i3c_device_match_id(struct i3c_device *i3cdev,
part = I3C_PID_PART_ID(devinfo.pid);
ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
inst = I3C_PID_INSTANCE_ID(devinfo.pid);
ext_info = ext_info | (inst << 12);
rndpid = I3C_PID_RND_LOWER_32BITS(devinfo.pid);

printk(" i3c_device_match_id: manuf 0x%x, part 0x%x, inst 0x%x, ext_info 0x%x \n", manuf, part, inst, ext_info);
Expand Down
4 changes: 2 additions & 2 deletions drivers/misc/amd-apml/sbrmi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,8 +752,8 @@ static const struct of_device_id __maybe_unused sbrmi_of_match[] = {
MODULE_DEVICE_TABLE(of, sbrmi_of_match);

static const struct i3c_device_id sbrmi_i3c_id[] = {
I3C_DEVICE_EXTRA_INFO(0, 0x000, 0x1118, NULL), /* P0 - IOD0 - SBRMI */
I3C_DEVICE_EXTRA_INFO(0, 0x100, 0x1118, NULL), /* P1 - IOD0 - SBRMI */
I3C_DEVICE_EXTRA_INFO(0, 0x000, 0x118, NULL), /* P0 - IOD0 - SBRMI */
Copy link
Copy Markdown
Collaborator

@mahkurap mahkurap Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbrmi ID is 0x1118 for Venice. pls check

Copy link
Copy Markdown
Collaborator Author

@akky16 akky16 Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i3c_device_match_id function is defined in file drivers/i3c/device.c where the manu_id, partid, ext_info are extracted and matched.
ext_info is assigned in file, drivers/i3c/device.c as
ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);

where I3C_PID_EXTRA_INFO is defined in file "include/linux/i3c/device.h" as
#define I3C_PID_EXTRA_INFO(pid) ((pid) & GENMASK_ULL(11, 0))

ext_info is 12 bit value, the bits [15:12] are the instance ID, which is not part of ext_info

I3C_DEVICE_EXTRA_INFO(0, 0x100, 0x118, NULL), /* P1 - IOD0 - SBRMI */
I3C_DEVICE_EXTRA_INFO(0x112, 0x0, 0x2, NULL),
I3C_DEVICE_EXTRA_INFO(0x112, 0x0, 0x118, NULL), /* Socket:0, IOD:0 */
Copy link
Copy Markdown
Collaborator

@mahkurap mahkurap Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbrmi additional id is 0x1118 not 0x118.

Copy link
Copy Markdown
Collaborator

@nchatrad nchatrad Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works on top of the DMA patches where the OR instance ID is removed.

Copy link
Copy Markdown
Collaborator Author

@akky16 akky16 Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i3c_device_match_id function is defined in file drivers/i3c/device.c where the manu_id, partid, ext_info are extracted and matched.
ext_info is assigned in file, drivers/i3c/device.c as
ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);

where I3C_PID_EXTRA_INFO is defined in file "include/linux/i3c/device.h" as
#define I3C_PID_EXTRA_INFO(pid) ((pid) & GENMASK_ULL(11, 0))

ext_info is 12 bit value, the bits [15:12] are the instance ID, which is not part of ext_info

I3C_DEVICE_EXTRA_INFO(0x112, 0x100, 0x118, NULL), /* Socket:1 IOD:0 */
Expand Down