pldm: Verbose pldmd sensor and effecter log messages

Log sensor read or parse errors only if pldmd is
running in verbose mode.

Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>

Author: spargaon

platform-mc/manager.hpp

@@ -40,7 +40,7 @@ class Manager : public pldm::MctpDiscoveryHandlerIntf
         terminusManager(event, handler, instanceIdDb, termini, this,
                         pldm::BmcMctpEid),
         platformManager(terminusManager, termini, this),
-        sensorManager(event, terminusManager, termini, this),
+        sensorManager(event, terminusManager, termini, this, verbose),
         eventManager(terminusManager, termini, verbose)
     {this->verbose = verbose;}
 
@@ -285,6 +285,7 @@ class Manager : public pldm::MctpDiscoveryHandlerIntf
     /** @brief map of PLDM event type to EventHandlers */
     PollHandlers pollHandlers;
 
+    /** @brief Enable verbose logging for debug purposes */
     bool verbose{false};
 };
 } // namespace platform_mc

platform-mc/sensor_manager.cpp

@@ -14,10 +14,11 @@ namespace platform_mc
 
 SensorManager::SensorManager(sdeventplus::Event& event,
                              TerminusManager& terminusManager,
-                             TerminiMapper& termini, Manager* manager) :
+                             TerminiMapper& termini, Manager* manager,
+                             const bool verbose) :
     event(event), terminusManager(terminusManager), termini(termini),
     pollingTime(SENSOR_POLLING_TIME), manager(manager)
-{}
+{this->verbose = verbose;}
 
 void SensorManager::startPolling(pldm_tid_t tid)
 {
@@ -270,9 +271,11 @@ exec::task<int> SensorManager::doSensorPollingTask(pldm_tid_t tid)
                 }
                 else
                 {
-                    lg2::error(
-                        "Failed to get sensor value for terminus {TID}, error: {RC}",
-                        "TID", tid, "RC", rc);
+                    if (verbose) {
+                       lg2::error(
+                           "Failed to get sensor value for terminus {TID}, error: {RC}",
+                           "TID", tid, "RC", rc);
+                    }
                 }
             }
 
@@ -351,9 +354,11 @@ exec::task<int> SensorManager::getSensorReading(
         reinterpret_cast<uint8_t*>(&presentReading));
     if (rc)
     {
-        lg2::error(
-            "Failed to decode response GetSensorReading for terminus ID {TID}, sensor Id {ID}, error {RC}.",
-            "TID", tid, "ID", sensorId, "RC", rc);
+        if (verbose) {
+           lg2::error(
+               "Failed to decode response GetSensorReading for terminus ID {TID}, sensor Id {ID}, error {RC}.",
+               "TID", tid, "ID", sensorId, "RC", rc);
+        }
         sensor->handleErrGetSensorReading();
         co_return rc;
     }

platform-mc/sensor_manager.hpp

@@ -40,7 +40,8 @@ class SensorManager
 
     explicit SensorManager(sdeventplus::Event& event,
                            TerminusManager& terminusManager,
-                           TerminiMapper& termini, Manager* manager);
+                           TerminiMapper& termini, Manager* manager,
+                           const bool verbose);
 
     /** @brief starting sensor polling task
      */
@@ -124,6 +125,9 @@ class SensorManager
 
     /** @brief pointer to Manager */
     Manager* manager;
+
+    /** @brief Enable verbose logging for debug purposes */
+    bool verbose{false};
 };
 } // namespace platform_mc
 } // namespace pldm