Skip to content

pldm: Numeric sensors & effecters: 0x6c, 0x1d #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spargaon wants to merge 1 commit into
base: integ_sp8
Choose a base branch
from
Open

pldm: Numeric sensors & effecters: 0x6c, 0x1d #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions configurations/pdr/com.amd.Hardware.Chassis/Processor0/13.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,14 @@
["en", "ResetOnSyncFloodStatus"]
]
},
{
"pdr_type": 13,
"effecter_id": 108,
"effecter_count": 1,
"effecter_names": [
["en", "TriggerSwSmi"]
]
},
{
"pdr_type": 13,
"effecter_id": 112,
Expand Down
12 changes: 12 additions & 0 deletions configurations/pdr/com.amd.Hardware.Chassis/Processor0/21.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,18 @@
"occurrence_rate": 0,
"range_field_support": 0
},
{
"pdr_type": 21,
"sensor_id": 108,
"entity_type": 135,
"entity_instance_number": 0,
"container_id": 0,
"sensor_name": "TriggerSwSmi",
"base_unit": 0,
"unit_modifier": 0,
"occurrence_rate": 0,
"range_field_support": 0
},
{
"pdr_type": 21,
"sensor_id": 112,
Expand Down
36 changes: 36 additions & 0 deletions configurations/pdr/com.amd.Hardware.Chassis/Processor0/9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,42 @@
"rated_max": 500000,
"rated_min": 0
},
{
"pdr_type": 9,
"effecter_id": 108,
"entity_type": 135,
"entity_instance_number": 0,
"container_id": 0,
"effecter_semantic_id": 0,
"effecter_init": 1,
"effecter_auxiliary_names_pdr": true,
"base_unit": 0,
"unit_modifier": 0,
"rate_unit": 0,
"base_oem_unit_handle": 0,
"aux_unit": 0,
"aux_unit_modifier": 0,
"aux_rate_unit": 0,
"aux_oem_unit_handle": 0,
"is_linear": true,
"effecter_data_size": 4,
"resolution": 1.0,
"offset": 0.0,
"accuracy": 0,
"plus_tolerance": 0,
"minus_tolerance": 0,
"state_transition_interval": 0,
"transition_interval": 0,
"max_settable": 500000,
Copy link
Copy Markdown
Collaborator

@mahkurap mahkurap May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check with PMFW and changes the max/min_settable, normal_min/max, and the rated parameters as well.

"min_settable": 0,
"range_field_format": 1,
"range_field_support": 1,
"nominal_value": 250000,
"normal_max": 400000,
"normal_min": 0,
"rated_max": 500000,
"rated_min": 0
},
{
"pdr_type": 9,
"effecter_id": 112,
Expand Down
8 changes: 8 additions & 0 deletions configurations/pdr/com.amd.Hardware.Chassis/Processor1/13.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,14 @@
["en", "ResetOnSyncFloodStatus"]
]
},
{
"pdr_type": 13,
"effecter_id": 108,
"effecter_count": 1,
"effecter_names": [
["en", "TriggerSwSmi"]
]
},
{
"pdr_type": 13,
"effecter_id": 112,
Expand Down
12 changes: 12 additions & 0 deletions configurations/pdr/com.amd.Hardware.Chassis/Processor1/21.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,18 @@
"occurrence_rate": 0,
"range_field_support": 0
},
{
"pdr_type": 21,
"sensor_id": 108,
"entity_type": 135,
"entity_instance_number": 0,
"container_id": 0,
"sensor_name": "TriggerSwSmi",
"base_unit": 0,
"unit_modifier": 0,
"occurrence_rate": 0,
"range_field_support": 0
},
{
"pdr_type": 21,
"sensor_id": 112,
Expand Down
36 changes: 36 additions & 0 deletions configurations/pdr/com.amd.Hardware.Chassis/Processor1/9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,42 @@
"rated_max": 500000,
"rated_min": 0
},
{
"pdr_type": 9,
"effecter_id": 108,
"entity_type": 135,
"entity_instance_number": 0,
"container_id": 0,
"effecter_semantic_id": 0,
"effecter_init": 1,
"effecter_auxiliary_names_pdr": true,
"base_unit": 0,
"unit_modifier": 0,
"rate_unit": 0,
"base_oem_unit_handle": 0,
"aux_unit": 0,
"aux_unit_modifier": 0,
"aux_rate_unit": 0,
"aux_oem_unit_handle": 0,
"is_linear": true,
"effecter_data_size": 4,
"resolution": 1.0,
"offset": 0.0,
"accuracy": 0,
"plus_tolerance": 0,
"minus_tolerance": 0,
"state_transition_interval": 0,
"transition_interval": 0,
"max_settable": 500000,
Copy link
Copy Markdown
Collaborator

@mahkurap mahkurap May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the max/min and the range values as per PMFW inputs.

"min_settable": 0,
"range_field_format": 1,
"range_field_support": 1,
"nominal_value": 250000,
"normal_max": 400000,
"normal_min": 0,
"rated_max": 500000,
"rated_min": 0
},
{
"pdr_type": 9,
"effecter_id": 112,
Expand Down