feat(config): preconfigure GPU accelerator override matrix#174
Merged
Conversation
Contributor
Author
|
Closing this draft while we reconsider how much GPU accelerator coverage should be exposed by default versus filtered by installer/environment overlays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visibility model
custom.acceleratorsis the curated accelerator catalog.metadata.<resource>.acceleratorOverridespredefines image routing for supported targets.metadata.<resource>.acceleratorKeysremains the deployment/admin-controlled visible set.strix-halounless an installer or environment overlay adds more keys.Override matrix
Installer behavior
latest-*overrides from replacing installer-specific images such asdevelop-gfx1151, custom registries, or offline bundle tags.Compatibility notes
acceleratorOverridesentries.acceleratorKeyslimited to accelerators actually exposed to users.Validation
pytest tests/installer/test_gpu.py tests/installer/test_overlay.py tests/installer/test_values_gpu_overrides.pyruntime/values.yamlandruntime/values-multi-nodes.yaml.examplegit diff --checkNotes
values.local.yamlunchanged in the repo.acceleratorKeys.