-
Notifications
You must be signed in to change notification settings - Fork 40
[WIP] allow for an alternate EOS table for the helmholtz EOS #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Here's a comparison of |
|
This has been updated now to use approximate functions for log and pow, and seems to get better performance. It needs more testing, in particular, the comparison of test_eos shows large-ish errors for |
|
just tested this again on Perlmutter / CUDA, and the alternate EOS table is no faster. The logs we are doing for indexing into the table are not the rate-limiting step. |


This will allow for a table generated by our new C++ EOS, which uses better quadrature and precision and should be more accurate overall for the electron-positron component.