Skip to content

a few fixes from cppcheck #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingale merged 1 commit into from
Jan 12, 2026
Merged

a few fixes from cppcheck #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integration/VODE/vode_dvjac.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ void dvjac (int& IERPJ, BurnT& state, DvodeT& vstate)

if (integrator_rp::use_jacobian_caching) {
evaluate_jacobian = 0;
}

if (integrator_rp::use_jacobian_caching) {
// Now evaluate the cases where we're caching the Jacobian but aren't
// going to be using the cached Jacobian.

Expand Down
9 changes: 4 additions & 5 deletions nse_solver/nse_check.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,10 @@ int get_root_index(const int nuc_ind,
// This function returns the root index of the nuclei
// by providing the nuclei index [0, NumSpec-1], and group indices, group_ind

int root_index;
int scratch_ind = nuc_ind;

while(true) {
root_index = group_ind(scratch_ind + 1);
int root_index = group_ind(scratch_ind + 1);

if (root_index != scratch_ind + 1) {
scratch_ind = root_index - 1;
Expand Down Expand Up @@ -166,9 +165,6 @@ bool in_single_group(const amrex::Array1D<int, 1, NumSpec>& group_ind) {

int nonLIG_index = -1;

int oddN_group = -1;
int evenN_group = -1;

bool in_single_group = true;

// Consider NSE when there is a single group with an optional LIG group
Expand Down Expand Up @@ -200,6 +196,9 @@ bool in_single_group(const amrex::Array1D<int, 1, NumSpec>& group_ind) {

in_single_group = true;

int oddN_group = -1;
int evenN_group = -1;

for (int n = 0; n < NumSpec; ++n) {

if (zion[n] >= 14) {
Expand Down
2 changes: 1 addition & 1 deletion unit_test/react_util.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ init_t setup_composition(const int nz) {


AMREX_INLINE AMREX_GPU_HOST_DEVICE
void get_xn(const int k, const init_t cd, amrex::Real *xn_zone, bool uniform_composition=false) {
void get_xn(const int k, const init_t& cd, amrex::Real *xn_zone, bool uniform_composition=false) {

for (int n = 0; n < NumSpec; n++) {
xn_zone[n] = 0.0_rt;
Expand Down
Loading