Catchup 10: Merge changes sync#44
Merged
Merged
Conversation
Generated from summary.csv view1-4. Ordered: NONE before LOW, mock drift first, DRY refactors before dependent sessions, integration tests after unit sessions. Includes dependency DAG and CI merge gate.
summary.csv: 398 criteria with confidence scores view1: 131 critical gaps view2: 16 mock drift items view3: 38 missing integration tests view4: 36 DRY violations
- validate manifest metadata with backward-compatible handling for legacy manifests - enforce embedding_model requirements for newer manifest versions and check configured model compatibility - update FAISS manifest build/download tooling and docs to carry embedding metadata
- strengthen manifest and sequence checks in graph, plan, and session orchestration paths - improve workflow store and reviewer-node handling for state consistency and traceability - expand contract and unit coverage for schema alignment and history/workflow behavior
- extend benchmark runner outputs and handling for clearer audit-oriented reporting - enhance aggregate metrics generation and metrics utility consistency - add unit coverage for benchmark execution, metrics collection, and result aggregation
- improve validator handling for edge cases and consistency of validation outcomes - add focused unit tests to guard expected validation behavior
- add broader MCP tool-path tests for contract and behavior stability - strengthen level0 index tests to protect retrieval regressions
- migrate useful scratch-session coverage into canonical plan, benchmark, and metrics test modules - remove session-specific naming from token-field normalization via normalize_average_token_fields - add migration-plan benchmark assertions and new plan factory/checklist behavior tests
jmsexton03
commented
Mar 26, 2026
Comment on lines
+29
to
+35
| _IMPLEMENTATION_LOCATION_KEYS = ( | ||
| "implementation_locations", | ||
| "implementation_location", | ||
| "locations", | ||
| "files", | ||
| "services", | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
this may be too hacky / global
Comment on lines
+614
to
+621
| def _deterministic_env_overrides(controls: dict[str, Any]) -> dict[str, str]: | ||
| seed = str(controls["seed"]) | ||
| return { | ||
| "PYTHONHASHSEED": seed, | ||
| "AMREX_AGENT_BENCHMARK_SEED": seed, | ||
| "AMREX_AGENT_DETERMINISTIC_REPLAY": "1", | ||
| "AMREX_AGENT_REPLAY_FINGERPRINT": str(controls["replay_fingerprint"]), | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This may not be secure or clear how it should work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10on branchcatchup_10_merge_changes_sync.8c1a41efb924..c18845b58a7b(sourceapply_stack_slice_110-> canonicalfix_stack_main)1/2/2/0(total5)fix_stack_mainat73f37cf9e86d.Related or overlapping functionality / DRY guidance
fix_stack_main); avoid duplicating logic that is already hardened in shared services/nodes.src/models/graph_state_canonical.pyandtests/contracts/*when touching shared flows.artifacts/integration/findings_reconciliation.jsonandartifacts/integration/fix_branch_remap_impact.md.docs/adr/(one short file describing context, decision, consequences).Impact checklist
Tests run (CI runs:
pytest tests/unit,pytest tests/quality,pytest tests/integration -m "integration_l1 or integration_l2 or integration_l3 or integration_l4 or integration_full")pytest tests/unitpytest tests/qualitypytest tests/integration -m "integration_l1 or integration_l2 or integration_l3 or integration_l4 or integration_full"fix_stack_mainnot executedfix_stack_main(73f37cf9e86d)1663 passed, 31 skipped, 3 warnings(coverage56.82%)1813 passed, 78 skipped, 10 xfailed, 11 warnings(coverage58.63%)20 passed, 1 skipped, 5 warnings47 passed, 36 skipped, 92 deselected, 1 xfailed, 7 warningsartifacts/integration/reports/fix_stack_main_20260318_034847/unit.junit.xml,artifacts/integration/reports/fix_stack_main_20260318_034847/full.junit.xmlrequires_solver(...)implies repo + schema + default indices are available locally.-k pelec|erf|amrex|warpxto filter solver-specific tests.Tests not run in CI (required if any)
tests/unit,tests/quality, andtests/integrationwithintegration_l1..l4+integration_fullmarkers via micromamba; list anything else not covered by CI here.fix_stack_main) rather than re-running each catchup branch independently.Notes (optional)
artifacts/integration/reports/fix_stack_main_20260318_034847total_findings=109,addressed=109artifacts/integration/fix_branch_remap_impact.mdfix_stack_mainartifacts.Labels (optional)