Catchup 13: Merge agent wave1 step#47
Merged
Merged
Conversation
- Enhances aggregate-metrics extraction for model/provider and strategy fields. - Adds grouped summary outputs and publication table generation paths. - Covers CLI/report outputs for directory and file input workflows.
- Hardens MCP session context merge/persist behavior with parent inheritance. - Adds server-side concurrent session handling safeguards. - Verifies workflow-store and MCP concurrency behavior end-to-end in tests.
- Adds non-blocking Tier 3/4 logging behavior to schema build workflow. - Improves config/schema integration guardrails for edge-case handling. - Covers builder/config boundary behavior with dedicated unit tests.
- Refines architect retrieval and solver-selection orchestration behavior. - Updates knowledge-service normalization and related orchestration tests. - Keeps sweep/orchestrator test expectations aligned with service behavior.
# Conflicts: # scripts/aggregate_metrics.py # src/config.py # src/graph.py # src/nodes/paper_validator_node.py # src/services/architect.py # src/services/plan.py # src/services/rules/base.py # src/session_manager.py # src/utils/metrics.py # tests/quality/test_standards.py # tests/unit/test_architect_node_history.py # tests/unit/test_benchmark_runner.py # tests/unit/test_level0_index.py # tests/unit/test_metrics_collector.py
…3_merge_agent_wave1_step
jmsexton03
commented
Mar 26, 2026
Comment on lines
+25
to
+35
| MAX_NEW_INTEGRATION_LOC = 300 | ||
| LEGACY_LOC_BUDGET_EXEMPT_CODES = { | ||
| "AMReX", | ||
| "PeleC", | ||
| "PeleLMeX", | ||
| "Incflo", | ||
| "WarpX", | ||
| "ERF", | ||
| "REMORA", | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
too specific, maybe this doesn't live here
jmsexton03
commented
Mar 26, 2026
jmsexton03
left a comment
jmsexton03
left a comment
Collaborator
Author
There was a problem hiding this comment.
Needs cleaner test names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
13on branchcatchup_13_merge_agent_wave1_step.f4206ae0fcbd..523aba32ad20(sourceapply_stack_slice_113-> canonicalfix_stack_main)3/0/2/0(total5)fix_stack_mainat73f37cf9e86d.Related or overlapping functionality / DRY guidance
fix_stack_main); avoid duplicating logic that is already hardened in shared services/nodes.src/models/graph_state_canonical.pyandtests/contracts/*when touching shared flows.artifacts/integration/findings_reconciliation.jsonandartifacts/integration/fix_branch_remap_impact.md.docs/adr/(one short file describing context, decision, consequences).Impact checklist
Tests run (CI runs:
pytest tests/unit,pytest tests/quality,pytest tests/integration -m "integration_l1 or integration_l2 or integration_l3 or integration_l4 or integration_full")pytest tests/unitpytest tests/qualitypytest tests/integration -m "integration_l1 or integration_l2 or integration_l3 or integration_l4 or integration_full"fix_stack_mainnot executedfix_stack_main(73f37cf9e86d)1663 passed, 31 skipped, 3 warnings(coverage56.82%)1813 passed, 78 skipped, 10 xfailed, 11 warnings(coverage58.63%)20 passed, 1 skipped, 5 warnings47 passed, 36 skipped, 92 deselected, 1 xfailed, 7 warningsartifacts/integration/reports/fix_stack_main_20260318_034847/unit.junit.xml,artifacts/integration/reports/fix_stack_main_20260318_034847/full.junit.xmlrequires_solver(...)implies repo + schema + default indices are available locally.-k pelec|erf|amrex|warpxto filter solver-specific tests.Tests not run in CI (required if any)
tests/unit,tests/quality, andtests/integrationwithintegration_l1..l4+integration_fullmarkers via micromamba; list anything else not covered by CI here.fix_stack_main) rather than re-running each catchup branch independently.Notes (optional)
artifacts/integration/reports/fix_stack_main_20260318_034847total_findings=109,addressed=109artifacts/integration/fix_branch_remap_impact.mdfix_stack_mainartifacts.Labels (optional)