fix_stack_main: consolidated closure + validation evidence#54
Merged
Conversation
…cation/capability contracts
…led clarifications
… and ERF fallbacks
Note: the merge from amrex-codes/development also introduced non-conflict updates in: - src/config.py (llm_provider literal dropped 'amsc-i2') - src/services/knowledge.py (argument ordering adjustments) - src/services/run_superfacility.py (removed walltime field from one event call)
jmsexton03
added a commit
that referenced
this pull request
Mar 26, 2026
…)" This reverts commit c742365.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidated fix-stack closure PR for
fix_stack_main.fix_stack_main73f37cf9e86dc86c4e19c83621bba10d1be63f84(short:73f37cf9)open_findings = 0)Closure Status
open_findings = 0and all slices markedfixed_on_stacked_branch.artifacts/integration/findings_reconciliation.{json,md}artifacts/integration/fix_branch_remap_impact.mdValidation Evidence
Run bundle:
artifacts/integration/reports/fix_stack_main_20260318_034847/10 passed, 3 warnings1663 passed, 31 skipped, 3 warnings1813 passed, 78 skipped, 10 xfailed, 11 warnings20 passed, 1 skipped, 5 warnings47 passed, 36 skipped, 92 deselected, 1 xfailed, 7 warningsTracked JUnit evidence:
artifacts/integration/reports/fix_stack_main_20260318_034847/unit.junit.xmlartifacts/integration/reports/fix_stack_main_20260318_034847/full.junit.xmlNotes