Skip to content

Fix target_link_libraries calls w/ alias target #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix target_link_libraries calls w/ alias target #147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf92f8
Fix target_link_libraries calls w/ alias target
nmnobre Dec 17, 2024
78c2f38
CMake: Remove `find_package(MPI)`
ax3l Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion GuidedTutorials/HeatEquation/Exec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ else()

# Add mpi
find_package(MPI REQUIRED)
target_link_libraries(AMReX::amrex INTERFACE ${MPI_LIBRARIES})
get_target_property(AMReX_ALIASED AMReX::amrex ALIASED_TARGET)
target_link_libraries(${AMReX_ALIASED} INTERFACE ${MPI_LIBRARIES})
Copy link
Member

@ax3l ax3l Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the tutorials have a specific dimensionality?

AMReX::amrex is for backwards compatibility and refers to the last-built spacedim (before, we could only build one -- keeping this target name around made transitions non-breaking/easier). But we have explicit AMReX::amrex_1d/AMReX::amrex_2d/AMReX::amrex_3d targets that we should now use.
https://github.com/AMReX-Codes/amrex/blob/041f225dc5c97a5e3baf2559046ceabffd75f002/Src/CMakeLists.txt#L8-L15


endif()

Expand Down
3 changes: 2 additions & 1 deletion GuidedTutorials/HeatEquation_Simple/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ else()

# Add mpi
find_package(MPI REQUIRED)
Copy link
Member

@ax3l ax3l Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny that we need MPI here at all, because if we need MPI, AMReX has to be built with MPI, which means MPI is already linked as a public transitive dependency in the AMReX::amrex_*d targets.

Copy link
Contributor Author

@nmnobre nmnobre Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMReX has to be built with MPI

Should we check for that? Or because we don't necessarily need MPI, do we just go with whatever the AMReX pkg we find already has (or has not)?

Copy link
Member

@ax3l ax3l Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I pushed a fix :)

target_link_libraries(AMReX::amrex INTERFACE ${MPI_LIBRARIES})
get_target_property(AMReX_ALIASED AMReX::amrex ALIASED_TARGET)
target_link_libraries(${AMReX_ALIASED} INTERFACE ${MPI_LIBRARIES})

endif()

Expand Down
3 changes: 2 additions & 1 deletion GuidedTutorials/HelloWorld/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ else()

# Add mpi
find_package(MPI REQUIRED)
target_link_libraries(AMReX::amrex INTERFACE ${MPI_LIBRARIES})
get_target_property(AMReX_ALIASED AMReX::amrex ALIASED_TARGET)
target_link_libraries(${AMReX_ALIASED} INTERFACE ${MPI_LIBRARIES})

endif()

Expand Down
3 changes: 2 additions & 1 deletion GuidedTutorials/MultiFab/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ else()

# Add mpi
find_package(MPI REQUIRED)
target_link_libraries(AMReX::amrex INTERFACE ${MPI_LIBRARIES})
get_target_property(AMReX_ALIASED AMReX::amrex ALIASED_TARGET)
target_link_libraries(${AMReX_ALIASED} INTERFACE ${MPI_LIBRARIES})

endif()

Expand Down
Loading