[WIP] Allow new levels on ParticleContainer restart #4424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's known that some versions of amrex::launch functions are not safe because they use AMREX_GPU_MAX_THREADS as the launch bound. Although they have an assertion for the number of threads per block, the unsafe amrex::launch functions are used in a few places resulting in runtime failures. This PR fixes these unsafe launch functions by removing the launch bound when we do not know the number of threads per block at compile time. We also pass the number of threads per block as a template parameter so that it can be used as the launch bound, when it's possible.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows ParticleContainer->Restart() to work when amr.max_level is increased on restart.
Includes #4426.
Additional background
Checklist
The proposed changes: