Skip to content

Conversation

srichers
Copy link

…signature for multifabs

Summary

Modify the CreateLike function in IntegratorBase so all template specializations have the same function signature.

Additional background

Used in initialize_stages called in, for example RKIntegrator.
Addresses #4656 I think.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

{

static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other)
static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool dummy = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

Suggested change
static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool dummy = false)
static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool /*dummy*/ = false)

to avoid unused parameter warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants