Clang-Tidy: modernize-use-ranges#5369
Open
WeiqunZhang wants to merge 3 commits into
Open
Conversation
WeiqunZhang
force-pushed
the
modernize-use-ranges
branch
2 times, most recently
from
d86c7c6 to
0db0947
Compare
WeiqunZhang
force-pushed
the
modernize-use-ranges
branch
6 times, most recently
from
8997d50 to
9ed2377
Compare
WeiqunZhang
force-pushed
the
modernize-use-ranges
branch
from
9ed2377 to
6949899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modernize-use-rangesis not a required check because (1) clang <= 15 have bugs withstd::ranges; (2)std::ranges::sortrequriresstd::sortable, which is stricter thanoperator<.Disable
readability-qualified-auto. It's just not right if we have to writeauto* itlo = std::ranges::find(m_lobc[0], BCType::Dirichlet);. It's an iterator, not really a pointer, even if it's a pointer in a particular implementation.