Fix getitem for cases with incomplete domains #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
added
the
bug: affects latest release
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
WeiqunZhang
approved these changes
Oct 23, 2024
ax3l
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the global indexing mechanism in
MultiFabthat is needed in cases where the box array does not fully cover the domain. In those cases, the__getitem__is done twice, once to get all of the data including places where the ghost cells internal to the domain cover places that are not covered by valid cells, and a second time to ensure that in places where the ghost cells do overlap valid cells, that the data used is from the valid cells.