Implement iMultiFab
#410
Merged
Implement iMultiFab
#410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
requested review from
EZoni,
RemiLehe,
WeiqunZhang,
dpgrote and
roelof-groenewald
This was referenced Jan 29, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # assign 3: loop through boxes and launch kernels | ||
| for mfi in imfab_device: | ||
| bx = mfi.tilebox().grow(ngv) # noqa |
Check notice
Code scanning / CodeQL
Unused local variable Note test
| # assign 3 | ||
| with cupyx.profiler.time_range("assign 3 [()]", color_id=0): | ||
| for mfi in imfab_device: | ||
| bx = mfi.tilebox().grow(ngv) # noqa |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning test
| return mm | ||
|
|
||
| for mfi in imfab_device: | ||
| bx = mfi.tilebox().grow(ngv) # noqa |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning test
| x[...] = 7 | ||
|
|
||
| for mfi in imfab_device: | ||
| bx = mfi.tilebox().grow(ngv) # noqa |
Check notice
Code scanning / CodeQL
Unused local variable Note test
| namespace | ||
| { | ||
| template<typename T> | ||
| void make_FabArray_T(py::module &m, std::string const &name) |
Check notice
Code scanning / CodeQL
Unused static function Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the
MultiFablogic and reuse as much as possible for theiMultiFabbindings.