Pywrapper for ba convert, surroundingnodes, and mf.copy #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| py_MultiFab | ||
| .def("copymf", |
Contributor
Author
There was a problem hiding this comment.
for some reason, calling this copy did not seem to work
May be there is another copy method that is shadowing this
so I renamed it as copymf and that works!
Member
There was a problem hiding this comment.
Is this different than the copy method exposed here?
Contributor
Author
There was a problem hiding this comment.
I tried using the copy_mfab in the python script and it did not work
So now I am not sure
they look similar, but copy_mfab did not work for me
Member
Contributor
Author
There was a problem hiding this comment.
discussed offline
.copy creates another copy and does not do what we want in this PR
where we copy the values from a src to dst multifab and the dst multifab is already allocated and initialized.
atmyers
approved these changes
Apr 24, 2025
RevathiJambunathan
force-pushed
the
pywrapper_ba_convert
branch
from
fe25313 to
7bcd163
Compare
RevathiJambunathan
force-pushed
the
pywrapper_ba_convert
branch
from
7bcd163 to
88c6008
Compare
RemiLehe
added a commit
to BLAST-WarpX/warpx
that referenced
this pull request
May 15, 2025
This PR exposes the multifab register so that when we create a local copy using pyamrex interface in a python script, 1. the multifab gets allocated and initialized 2. this allows the multifab to also be redistributed during load balancing 3. when finalize is called, the multifab memory is cleared in a clean way This PR AMReX-Codes/pyamrex#439) adds wrappers to ba.convert, ba.surroundingNodes, mf.copy so now , we could add a new "test_mf" with desired nodality ``` reg.alloc_init("test_nf",0,warpx.boxArray(0).convert(amrex.IntVect(1,1)),warpx.DistributionMap(0), 1,amrex.IntVect(1,1),0.0,True,True) ``` <img width="637" alt="Screenshot 2025-05-14 at 10 58 19 AM" src="https://github.com/user-attachments/assets/ecc3a5ae-9ce1-4b32-82ad-169167d8dfdb" /> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Remi Lehe <[email protected]>
atmyers
pushed a commit
to atmyers/WarpX
that referenced
this pull request
Jul 3, 2025
This PR exposes the multifab register so that when we create a local copy using pyamrex interface in a python script, 1. the multifab gets allocated and initialized 2. this allows the multifab to also be redistributed during load balancing 3. when finalize is called, the multifab memory is cleared in a clean way This PR AMReX-Codes/pyamrex#439) adds wrappers to ba.convert, ba.surroundingNodes, mf.copy so now , we could add a new "test_mf" with desired nodality ``` reg.alloc_init("test_nf",0,warpx.boxArray(0).convert(amrex.IntVect(1,1)),warpx.DistributionMap(0), 1,amrex.IntVect(1,1),0.0,True,True) ``` <img width="637" alt="Screenshot 2025-05-14 at 10 58 19 AM" src="https://github.com/user-attachments/assets/ecc3a5ae-9ce1-4b32-82ad-169167d8dfdb" /> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Remi Lehe <[email protected]>
rho-novatron
pushed a commit
to novatron-fusion/WarpX
that referenced
this pull request
Oct 7, 2025
This PR exposes the multifab register so that when we create a local copy using pyamrex interface in a python script, 1. the multifab gets allocated and initialized 2. this allows the multifab to also be redistributed during load balancing 3. when finalize is called, the multifab memory is cleared in a clean way This PR AMReX-Codes/pyamrex#439) adds wrappers to ba.convert, ba.surroundingNodes, mf.copy so now , we could add a new "test_mf" with desired nodality ``` reg.alloc_init("test_nf",0,warpx.boxArray(0).convert(amrex.IntVect(1,1)),warpx.DistributionMap(0), 1,amrex.IntVect(1,1),0.0,True,True) ``` <img width="637" alt="Screenshot 2025-05-14 at 10 58 19 AM" src="https://github.com/user-attachments/assets/ecc3a5ae-9ce1-4b32-82ad-169167d8dfdb" /> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Remi Lehe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.