Fixes in MultiFab setitem #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was only checking for numpy array. This fix makes it more flexible.
for more information, see https://pre-commit.ci
dpgrote
changed the title
Contributor
|
Thank you @dpgrote for this PR!! |
atmyers
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
setitemwas only checking for numpy arrays, which was causing errors on a GPU when a cupy array was passed in. This fix makes it more flexible, so now lists can also be used for example.Also, when using GPU, the input value must be converted to a cupy array before the copy can be done.
A minor cleanup of
_get_fieldis also done, simplifying the code.