Fix RealVect crossProduct

[AlexanderSinn]

Another fix for AMReX-Codes/amrex#4430

[AlexanderSinn]

I think with .def("crossProduct", &RealVect::crossProduct<>, it also worked with amrex development but not amrex release. I only converted about half the CI tests to development. But with pyamrex_realvect_crossproduct it works with both versions.

[WeiqunZhang]

Oh I didn't realize that the failed tests were still using an old version of amrex. No wonder those error messages didn't make sense. Anyway, please revert my changes because it is too complicated.

…

On Tue, May 13, 2025, 1:45 AM Alexander Sinn ***@***.***> wrote: *AlexanderSinn* left a comment (AMReX-Codes/pyamrex#445) <#445 (comment)> I think with .def("crossProduct", &RealVect::crossProduct<>, it also worked with amrex development but not amrex release. I only converted about half the CI tests to development. But with pyamrex_realvect_crossproduct it works with both versions. — Reply to this email directly, view it on GitHub <#445 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB37TYK2NPAKJQJU5SFISBL26GWK3AVCNFSM6AAAAAB46ZZBA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZVGU4DEMBWGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[WeiqunZhang]

Should we switch to using amrex development in CI?

[AlexanderSinn]

Probably should. However, I don't know how to change the amrex branch in the tests where pyamrex is compiled with pip

[WeiqunZhang]

That might be difficult.

[ax3l]

@WeiqunZhang @AlexanderSinn I rather would, as in other projects, add pyAMReX to the app tests in AMReX and then manually update here the commits weekly (and on demand for breaking PRs). That gives us more control

[ax3l]

Only cmake/dependencies/AMReX.cmake needs to be updated here, as we do in WarpX/ImpactX/HiPACE++.

See #446 and #379 as examples